Make deletion protection consistent across all modules #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
reviewed
Oct 5, 2023
ludoo
approved these changes
Oct 5, 2023
juliocc
changed the title
ludoo
approved these changes
Oct 5, 2023
juliocc
force-pushed
the
jccb/gke-deletion-protection
branch
from
6c93cb3 to
350e952
Compare
|
@lcaggio this mostly affects the data blueprints. Can you take a look and make sure I'm not breaking anything? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
deletion_protectionattributed in GKE clusters introduced in version 5 of the provider.Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py