Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Data Platform - Fix #1730

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Minimal Data Platform - Fix #1730

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7d140f
Fix
lcaggio Oct 4, 2023
17c6b44
Merge branch 'master' into lcaggio/mdp-fix
lcaggio Oct 4, 2023
2e876ea
Fix README
lcaggio Oct 4, 2023
2042f62
Fix data platform minimal tests
juliocc Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions blueprints/data-solutions/data-platform-minimal/02-composer.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ locals {
DP_REGION = var.region
LAND_PRJ = module.land-project.project_id
LAND_GCS = module.land-cs-0.url
LAND_BQ_DATASET = module.land-bq-0.dataset_id
PHS_CLUSTER_NAME = try(module.processing-dp-historyserver[0].name, "")
PROCESSING_GCS = module.processing-cs-0.url
PROCESSING_PRJ = module.processing-project.project_id
Expand Down
4 changes: 1 addition & 3 deletions blueprints/data-solutions/data-platform-minimal/02-processing.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,7 @@ module "processing-project" {
iam_bindings_additive = (
var.project_config.billing_account_id != null ? {} : local.iam_prc_additive
)
compute_metadata = {
enable-oslogin = "false"
}

services = [
"bigquery.googleapis.com",
"bigqueryreservation.googleapis.com",
Expand Down
Loading