Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add materialized views for bigquery #1726

Merged
merged 16 commits into from
Oct 4, 2023
Merged

Add materialized views for bigquery #1726

merged 16 commits into from
Oct 4, 2023

Conversation

devuonocar
Copy link
Contributor

  • Added field and partition filter to time_partitioning for bq table
  • Added Materialized view

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@devuonocar devuonocar force-pushed the devuonocar/add-features-to-bigquery-table branch from 60442e3 to 91d8471 Compare October 4, 2023 08:16
wiktorn
wiktorn approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. It looks like you need to re-run tfdoc.

ludoo
ludoo requested changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice PR. Dropped a couple comments.

modules/bigquery-dataset/variables.tf Outdated Show resolved Hide resolved
modules/bigquery-dataset/main.tf Show resolved Hide resolved
ludoo
ludoo approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the very nice PR!

@ludoo
Copy link
Collaborator

ludoo commented Oct 4, 2023

You just need to rerun tfdoc

@devuonocar devuonocar requested review from ludoo and wiktorn October 4, 2023 12:00
@ludoo ludoo enabled auto-merge (squash) October 4, 2023 12:07
@ludoo ludoo merged commit 7503bce into GoogleCloudPlatform:master Oct 4, 2023
@devuonocar devuonocar deleted the devuonocar/add-features-to-bigquery-table branch October 4, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devuonocar @ludoo @wiktorn