Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deletion_protection_enabled attribute to cloudsql-instance to ena… #1696

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add deletion_protection_enabled attribute to cloudsql-instance to ena… #1696

merged 1 commit into from
Sep 20, 2023

Conversation

steenblik
Copy link
Collaborator

Add the GCP native deletion protection flag to cloudsql-instance

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

ludoo
ludoo approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ludoo ludoo merged commit 79b0dc9 into GoogleCloudPlatform:master Sep 20, 2023
9 checks passed
@steenblik steenblik deleted the steenblik/cloudsql-google-deletion-protection branch November 21, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steenblik @ludoo