Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING guide: fix broken links and update "running tests for specific examples" section #1686

Conversation

olliefr
Copy link
Collaborator

@olliefr olliefr commented Sep 16, 2023

  • Fix two broken links to section headers.
  • Fix and expand the examples in the Running tests for specific examples section.

I recalled that I initially had some difficulties running the commands from that section. Now that I got the gist of it, I would like to propose a few changes. I fixed the examples that despite their description returned ambiguous results and added a few more examples of targeting specific tests.

Happy to provide more details, if need be 🙂

Checklist

I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You're on a roll :)

@ludoo ludoo enabled auto-merge (squash) September 16, 2023 19:46
@ludoo ludoo merged commit 1c5aabb into GoogleCloudPlatform:master Sep 16, 2023
@olliefr olliefr deleted the olliefr/fix-contributing-guide branch September 17, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants