Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed subnet-level IAM in the variables controlling creation of subnets #1681

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Sep 14, 2023

This moves the top-level iam, iam_bindings and iam_bindings_additive variables into subnet-level attributes. This change also allows setting permissions to PSC or proxy-only subnets

As part of this change, the factory interface is more aligned with the rest of the modules using a factories_config variable. In the future we can add a cidrs template similar to the firewall policy module


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc marked this pull request as ready for review September 14, 2023 22:08
@juliocc juliocc requested a review from ludoo September 14, 2023 22:08
@juliocc juliocc enabled auto-merge September 14, 2023 22:12
This moves the top-level `iam`, `iam_bindings` and
`iam_bindings_additive` variables into subnet-level attributes. This
change also allows setting permissions to PSC or proxy-only subnets

As part of this change, the factory interface is more aligned with the
rest of the modules using a `factories_config` variable. In the future
we can add a cidrs template similar to the firewall policy module
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful stuff

@juliocc juliocc merged commit 0221198 into master Sep 15, 2023
13 checks passed
@juliocc juliocc deleted the jccb/subnet-iam branch September 15, 2023 06:42
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints on:FAST on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants