Upgrades to monitoring_config in gke-cluster-*, docs update, and cosmetics fixes to GKE cluster modules
#1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add tests. Update docs.
|
This is a draft pull request at this point because I had not fixed FAST and other potential issues due to change in interface for monitoring configuration. |
|
I can't believe I got through this haha 😆 Please have a look as I don't have a full awareness of how the blueprints and FAST are interconnected so am anxious to break things 😅 |
juliocc
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now both GKE cluster modules (Standard and Autopilot) use the same style for configuring logging and monitoring.
monitoring_configingke-cluster-standardto use the object interface.Closes #1665
Checklist
I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py