Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow only one of secondary_range_blocks or secondary_range_names when creating GKE clusters. #1678

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Allow only one of secondary_range_blocks or secondary_range_names when creating GKE clusters. #1678

merged 6 commits into from
Sep 14, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Sep 14, 2023

Allow only one of secondary_range_blocks or secondary_range_names when create GKE clusters. Also removes a couple of useless try()

Fixes #1677

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc requested a review from olliefr September 14, 2023 10:58
@juliocc juliocc mentioned this pull request Sep 14, 2023
Closed
@juliocc juliocc enabled auto-merge September 14, 2023 11:10
@juliocc juliocc merged commit 96a3bc3 into master Sep 14, 2023
13 checks passed
@juliocc juliocc deleted the jccb/fix-1677 branch September 14, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@olliefr olliefr Awaiting requested review from olliefr

Assignees
No one assigned
Labels
on:blueprints on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with var.vpc_config.secondary_range_* in gke-cluster-* modules
2 participants
@juliocc @ludoo