fix(compute-mig): add correct type optionality for metrics in autosca… #1668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
//modules/compute-mig
module there is a mismatch between the optionality of types and what the upstream terraform docs mention forautoscaler_config.metrics.(type|target_value)
. It seems only theautoscaler_config.metrics.name
type is required.Notes
I've ran
tools/tfdoc.py
but linting seems to be failing, can maintainers PTAL?Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py