Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge labels from data_merges in project factory #1662

Merged
merged 3 commits into from
Sep 8, 2023
Merged

merge labels from data_merges in project factory #1662

merged 3 commits into from
Sep 8, 2023

Conversation

Tutuchan
Copy link
Contributor

@Tutuchan Tutuchan commented Sep 8, 2023 •
edited
Loading

The labels key in data_merges in the project-factory blueprint was the only one not being merged.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@ludoo
Copy link
Collaborator

ludoo commented Sep 8, 2023

Thanks a lot for spotting this! Can you also fix the failing test, which now see the merged labels?

@ludoo ludoo enabled auto-merge (squash) September 8, 2023 09:47
auto-merge was automatically disabled September 8, 2023 09:56

Head branch was pushed to by a user without write access

@ludoo ludoo enabled auto-merge (squash) September 8, 2023 10:08
@ludoo ludoo merged commit e141b86 into GoogleCloudPlatform:master Sep 8, 2023
@Tutuchan Tutuchan deleted the merge-labels-project-factory branch September 8, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tutuchan @ludoo