Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link project factory documentation from FAST stage #1659

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Sep 8, 2023

Fixes #1628

@ludoo ludoo enabled auto-merge (squash) September 8, 2023 06:44
@ludoo ludoo merged commit e14789e into master Sep 8, 2023
@ludoo ludoo deleted the ludo/issue-1628 branch September 8, 2023 07:14
@gustavovalverde
Copy link
Contributor

I don't think this solves the problem if someone uses the available sample file in the stage:

Most people would commonly adapt the sample to their use case, but if the sample has the wrong data types, then it will crash for newcomers, unless they start digging into each dependency and their documentation.

I'm using that same file structure, as shared here:

I would say adapting the file would be the missing part, as done here:

@ludoo
Copy link
Collaborator Author

ludoo commented Sep 8, 2023

Good point, let me nuke the stale file out of existence. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stages: document how the new factory_data is meant to be used
3 participants