Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to the apigee module #1653

Merged
merged 8 commits into from
Sep 7, 2023
Merged

Fixes to the apigee module #1653

merged 8 commits into from
Sep 7, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Sep 7, 2023 •
edited
Loading

Alternative implementation to #1648

  • Allows creating organizations without configuring the VPC peering to the tenant network
  • Allows creating instances without the troubleshooting range
  • Allows the user to override the instance name

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc
Copy link
Collaborator Author

juliocc commented Sep 7, 2023

@wiktorn can you tal?

@g-greatdevaks g-greatdevaks mentioned this pull request Sep 7, 2023
Closed
4 tasks
@juliocc
Merge pull request #1655 from g-greatdevaks/apigee-psc-peering-mode
cd8da98 
add tests and update readme for apigee psc peering
@wiktorn
Copy link
Collaborator

wiktorn commented Sep 7, 2023

LGTM

@wiktorn wiktorn mentioned this pull request Sep 7, 2023
Closed
4 tasks
@cygnus8595 cygnus8595 mentioned this pull request Sep 7, 2023
Closed
@juliocc juliocc merged commit 63bf9ec into master Sep 7, 2023
@juliocc juliocc deleted the jccb/apigee-fixes branch September 7, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliocc @wiktorn @g-greatdevaks