Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AIRFLOW_VAR_ prefix to environment variables in data-platform blueprints #1651

Merged

Conversation

Tutuchan
Copy link
Contributor

@Tutuchan Tutuchan commented Sep 6, 2023

As discussed in #1649, this PR adds the AIRFLOW_VAR_ prefix to all environment variables in the data-platform-foundations and data-platform-minimal blueprints, to enable them being used as Airflow Variables.

I also updated the example DAGs based on this change + took the liberty to remove unused imports.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

I add one test failing locally -- tests/modules/cloud_function_v2/examples/iam.yaml but I don't see how it's related to this change.

@google-cla
Copy link

google-cla bot commented Sep 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@lcaggio lcaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Tutuchan
Copy link
Contributor Author

Tutuchan commented Sep 6, 2023

Thanks for the approval @lcaggio, I'm waiting for an answer internally about the CLA, I'll get back to the PR when it has moved forward.

@Tutuchan
Copy link
Contributor Author

Tutuchan commented Sep 7, 2023

Just FYI, CLA has been approved internally, we are waiting for the Google review which should take a few days.

@ludoo ludoo enabled auto-merge (squash) September 8, 2023 06:48
@ludoo
Copy link
Collaborator

ludoo commented Sep 8, 2023

Fixes #1649

@ludoo ludoo merged commit 0e7cfc8 into GoogleCloudPlatform:master Sep 8, 2023
@Tutuchan Tutuchan deleted the tutuchan/add-airflow-var-prefix branch September 8, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants