-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AIRFLOW_VAR_ prefix to environment variables in data-platform blueprints #1651
add AIRFLOW_VAR_ prefix to environment variables in data-platform blueprints #1651
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Thanks for the approval @lcaggio, I'm waiting for an answer internally about the CLA, I'll get back to the PR when it has moved forward. |
Just FYI, CLA has been approved internally, we are waiting for the Google review which should take a few days. |
Fixes #1649 |
As discussed in #1649, this PR adds the
AIRFLOW_VAR_
prefix to all environment variables in the data-platform-foundations and data-platform-minimal blueprints, to enable them being used as Airflow Variables.I also updated the example DAGs based on this change + took the liberty to remove unused imports.
Checklist
I applicable, I acknowledge that I have:
terraform fmt
on all modified filestools/tfdoc.py
I add one test failing locally --
tests/modules/cloud_function_v2/examples/iam.yaml
but I don't see how it's related to this change.