Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gke-cluster-autopilot: add monitoring configuration #1646

Conversation

olliefr
Copy link
Collaborator

@olliefr olliefr commented Sep 3, 2023

Although one cannot disable Cloud Monitoring integration in GKE Autopilot clusters, one has some flexibility over which control plane components' metrics should be ingested: manage GKE metrics.

This PR adds a new input variable monitoring_config and a block to the cluster resource to facilitate that. The variable is optional with a sensible default value.

The interface is similar in style to #1625. Since there was no monitoring configuration in place for this module previously, it is not likely for this PR to break any existing code 🙏

I've added an example to the README as well.

Feedback is welcome 🙃

Checklist

If applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olliefr thanks for this!

Does it make sense to have the same variable for standard clusters?

@olliefr
Copy link
Collaborator Author

olliefr commented Sep 4, 2023

@juliocc the standard cluster module already has it: monitoring_config.

Like the logging_config before, it's not an object interface though. My plan is to implement the object interface for the standard clusters module as well but I'd like to do it in a separate PR because the surface of work is much greater for the standard clusters - the configuration is more flexible for standard clusters and there are existing uses of the module, just like we had with logging.

@juliocc
Copy link
Collaborator

juliocc commented Sep 4, 2023

@juliocc the standard cluster module already has it: monitoring_config.

Like the logging_config before, it's not an object interface though. My plan is to implement the object interface for the standard clusters module as well but I'd like to do it in a separate PR because the surface of work is much greater for the standard clusters - the configuration is more flexible for standard clusters and there are existing uses of the module, just like we had with logging.

Sounds good. You can merge this one then.

@olliefr olliefr merged commit 9f23d50 into GoogleCloudPlatform:master Sep 4, 2023
@olliefr olliefr deleted the olliefr/gke-cluster-autopilot-monitoring-config branch September 5, 2023 13:27
simonebruzzechesse pushed a commit that referenced this pull request Sep 5, 2023
* gke-cluster-autopilot: add monitoring configuration block (monitoring_config)
simonebruzzechesse pushed a commit that referenced this pull request Sep 5, 2023
* gke-cluster-autopilot: add monitoring configuration block (monitoring_config)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants