Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New phpIPAM serverless third parties solution in blueprints #1642

Merged
merged 10 commits into from
Sep 7, 2023

Conversation

simonebruzzechesse
Copy link
Collaborator

Added new phpIPAM third party solution blueprint.


I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't gone in detail but here are a few comments

blueprints/third-party-solutions/phpipam/glb.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/glb.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/glb.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/README.md Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/README.md Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/README.md Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/README.md Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/README.md Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/main.tf Outdated Show resolved Hide resolved
blueprints/third-party-solutions/phpipam/variables.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments. Sorry, after this I'm done :)

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my side. Good luck with @LucaPrete

@simonebruzzechesse simonebruzzechesse merged commit 77c1e69 into master Sep 7, 2023
@simonebruzzechesse simonebruzzechesse deleted the bruzz/phpipam branch September 7, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants