Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify linting output in workflow #1640

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Simplify linting output in workflow #1640

merged 1 commit into from
Aug 31, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Aug 31, 2023 •
edited
Loading

  • Only print liniting failures in GH workflows
  • Provide a user-friendly script (tools/lint.sh) to run all checks in one go

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc requested a review from ludoo August 31, 2023 08:18
@github-actions github-actions bot added on:tools New or changed tool on:documentation labels Aug 31, 2023
@juliocc juliocc merged commit f9dc605 into master Aug 31, 2023
@juliocc juliocc deleted the jccb/nicer-lint branch August 31, 2023 09:16
@juliocc juliocc mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:documentation on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @ludoo