Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set default ASN number #1633

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Do not set default ASN number #1633

merged 2 commits into from
Aug 28, 2023

Conversation

LucaPrete
Copy link
Member

This is the original cause of FAST stages failing if an ASN is not provided (recently added back with this patch).

After talking with @juliocc it seems long AS numbers may not be ingested properly if applied from a 32 bit system, so it would be better to avoid them.

On the other hand, a default ASN number is not really needed for Cloud NAT.

As a result

  • with this patch we move to optional the cloud nat module ASN (not required by APIs)
  • as soon as this goes in, we'll revert (again!) the FAST ASN patch --> meaning, we will no longer specify ASNs in FAST

@LucaPrete LucaPrete enabled auto-merge (squash) August 28, 2023 14:49
@LucaPrete LucaPrete merged commit 9d0fd74 into master Aug 28, 2023
@LucaPrete LucaPrete deleted the cloudnat_remove_asn branch August 28, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants