Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net-firewall-policy match variable validation #1620

Conversation

richard-olson
Copy link
Contributor

The current Terraform validation for the match variable in the net-firewall-policy module prevents the use of new match options such as FQDNs and Threat Intelligence unless they are combined with destination/source range for egress and ingress rules respectively.

Per #1615 the preferred approach would be to remove the validation check.

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have to run tfdoc.py to update the readme.

@juliocc juliocc enabled auto-merge August 24, 2023 17:29
@juliocc juliocc merged commit 2d3dae1 into GoogleCloudPlatform:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants