optional description in modules/net-vpc-swp #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, so I will probably add more different variables for description to have more flexibility. So gimme a sec. |
|
Please don't add variables. |
|
What I mean a top-level optional description for the main resource is fine, all the rest should be optional attributes in existing object type variables. |
|
I have talked to Taneli, we decided on adding another top-level variable, because otherwise it makes very little sense and makes the code very ugly. Please take a look, this is now ready for review. |
ludoo
reviewed
Aug 1, 2023
ludoo
reviewed
Aug 1, 2023
ludoo
reviewed
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1491