Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of dns module #1510

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Refactoring of dns module #1510

merged 1 commit into from
Jul 19, 2023

Conversation

apichick
Copy link
Collaborator

No description provided.

@apichick apichick force-pushed the dns-module-refactoring branch from c907fd7 to 6dbe134 Compare July 19, 2023 10:48
ludoo
ludoo approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR!

@apichick apichick force-pushed the dns-module-refactoring branch from 6dbe134 to a69e65b Compare July 19, 2023 10:50
@apichick apichick enabled auto-merge July 19, 2023 10:51
@apichick apichick force-pushed the dns-module-refactoring branch from df270ff to cacb0c0 Compare July 19, 2023 10:57
@apichick apichick merged commit 84eb5f0 into GoogleCloudPlatform:master Jul 19, 2023
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apichick @ludoo