Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a few files to fix typos #1483

Merged
merged 2 commits into from
Jun 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ All notable changes to this project will be documented in this file.
- [[#1006](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1006)] Add settings for autoscaling to Bigtable module. ([iht](https://github.com/iht)) <!-- 2022-11-24 15:59:32+00:00 -->
- [[#999](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/999)] Default nodepool creation fix ([astianseb](https://github.com/astianseb)) <!-- 2022-11-22 18:17:58+00:00 -->
- [[#1005](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1005)] Only set partitioned table when sink type is bigquery ([juliocc](https://github.com/juliocc)) <!-- 2022-11-22 16:13:53+00:00 -->
- [[#997](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/997)] Add BigQuery subcriptions to Pubsub module. ([iht](https://github.com/iht)) <!-- 2022-11-21 17:26:52+00:00 -->
- [[#997](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/997)] Add BigQuery subscriptions to Pubsub module. ([iht](https://github.com/iht)) <!-- 2022-11-21 17:26:52+00:00 -->
- [[#995](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/995)] Push container images to GitHub instead of Google Container Registry ([kunzese](https://github.com/kunzese)) <!-- 2022-11-21 14:53:52+00:00 -->
- [[#994](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/994)] Add schemas to Pubsub topic module. ([iht](https://github.com/iht)) <!-- 2022-11-20 16:56:03+00:00 -->
- [[#979](https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/979)] Add network tags support to the organization module ([LucaPrete](https://github.com/LucaPrete)) <!-- 2022-11-18 14:56:29+00:00 -->
Expand Down Expand Up @@ -902,8 +902,8 @@ All notable changes to this project will be documented in this file.
- added `environment` and `context` resource management tags
- use resource management tags to restrict scope of roles/orgpolicy.policyAdmin
- use `xpnServiceAdmin` (custom role) for stage 3 service accounts that need to attach to a shared VPC
- simplify and standarize ourputs from each stage
- standarize names of projects, service accounts and buckets
- simplify and standardize ourputs from each stage
- standardize names of projects, service accounts and buckets
- switch to folder-level `xpnAdmin` and `xpnServiceAdmin`
- moved networking projects to folder matching their environments

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ You can find examples in the `[demo](./demo)` folder.
| [df_template](outputs.tf#L49) | Dataflow template image and template details. | |
| [gcs-buckets](outputs.tf#L58) | GCS buckets. | |
| [kms_keys](outputs.tf#L71) | Cloud MKS keys. | |
| [projects](outputs.tf#L76) | GCP Projects informations. | |
| [projects](outputs.tf#L76) | GCP Projects information. | |
| [vpc_network](outputs.tf#L102) | VPC network. | |
| [vpc_subnet](outputs.tf#L111) | VPC subnetworks. | |

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ output "kms_keys" {
}

output "projects" {
description = "GCP Projects informations."
description = "GCP Projects information."
value = {
project_number = {
dwh-landing = module.dwh-lnd-project.number,
Expand Down
2 changes: 1 addition & 1 deletion blueprints/data-solutions/data-platform-minimal/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ The application layer is out of scope of this script. As a demo purpuse only, on
| [gcs_buckets](outputs.tf#L38) | GCS buckets. | |
| [kms_keys](outputs.tf#L47) | Cloud MKS keys. | |
| [network](outputs.tf#L52) | VPC network. | |
| [projects](outputs.tf#L60) | GCP Projects informations. | |
| [projects](outputs.tf#L60) | GCP Projects information. | |
| [service_accounts](outputs.tf#L78) | Service account created. | |

<!-- END TFDOC -->
2 changes: 1 addition & 1 deletion blueprints/data-solutions/data-platform-minimal/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ output "network" {
}

output "projects" {
description = "GCP Projects informations."
description = "GCP Projects information."
value = {
project_number = {
common = module.common-project.number
Expand Down
2 changes: 1 addition & 1 deletion fast/stages/3-data-platform/dev/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ You can find examples in the `[demo](../../../../blueprints/data-solutions/data-
| [demo_commands](outputs.tf#L47) | Demo commands. | | |
| [gcs_buckets](outputs.tf#L52) | GCS buckets. | | |
| [kms_keys](outputs.tf#L57) | Cloud MKS keys. | | |
| [projects](outputs.tf#L62) | GCP Projects informations. | | |
| [projects](outputs.tf#L62) | GCP Projects information. | | |
| [vpc_network](outputs.tf#L67) | VPC network. | | |
| [vpc_subnet](outputs.tf#L72) | VPC subnetworks. | | |

Expand Down
2 changes: 1 addition & 1 deletion fast/stages/3-data-platform/dev/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ output "kms_keys" {
}

output "projects" {
description = "GCP Projects informations."
description = "GCP Projects information."
value = module.data-platform.projects
}

Expand Down