Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bigquery authorized resources #1480

Merged
merged 17 commits into from
Jun 30, 2023

Conversation

thinhha
Copy link
Contributor

@thinhha thinhha commented Jun 29, 2023

Add options to include bigquery authorized resources. I tried to also make the change backwards compatible with the existing approach to create authorized views via the access block.

This is my first PR to this repo. I don't fully understand how the tests work. Any feedback will be much welcomed.

@lcaggio
Copy link
Collaborator

lcaggio commented Jun 29, 2023

Thanks for contributing and implementing such a great feature to have.

To fix the linting error, you can create the variables/output section with the tfdocs.py tool.

./tools/tfdoc.py modules/my-changed-module

For more details take a look at the CONTRIBUTING.md file.

@thinhha thinhha requested a review from lcaggio June 29, 2023 10:29
Copy link
Collaborator

@lcaggio lcaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great addition. few comments.

modules/bigquery-dataset/README.md Show resolved Hide resolved
modules/bigquery-dataset/outputs.tf Outdated Show resolved Hide resolved
modules/bigquery-dataset/outputs.tf Outdated Show resolved Hide resolved
modules/bigquery-dataset/outputs.tf Outdated Show resolved Hide resolved
modules/bigquery-dataset/variables.tf Show resolved Hide resolved
@thinhha
Copy link
Contributor Author

thinhha commented Jun 30, 2023

could you please take another look? Thank you @lcaggio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants