Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the IP range of pods from 100.64.48.0/20 to 100.65.16.0/20 Fixes #1461 #1477

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

arvindag07
Copy link
Contributor

@arvindag07 arvindag07 commented Jun 28, 2023

-> Changing the IP range of pods from 100.64.48.0/20 to 100.65.16.0/20 in fast/stages/2-networking-a-peering/data/subnets/dev/dev-dataplatform-ew1.yaml as there is an overlap in 100.64.0.0/16 range with fast/stages/2-networking-a-peering/data/subnets/dev/dev-gke-nodes-ew1.yaml1 "Fixes #1461"

…as there is an overlap in 100.64.0.0/16 range with dev-gke-nodes-ew1.yaml
@juliocc juliocc linked an issue Jun 28, 2023 that may be closed by this pull request
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and you need to do the same in the other networking stages

@arvindag07
Copy link
Contributor Author

arvindag07 commented Jun 28, 2023

Changed the IP ranges in all networking stages

@arvindag07 arvindag07 changed the title Changing the IP range of pods from 100.64.48.0/20 to 100.65.16.0/20 … Changing the IP range of pods from 100.64.48.0/20 to 100.65.16.0/20 Fixes #1461 Jun 28, 2023
@arvindag07
Copy link
Contributor Author

arvindag07 commented Jun 28, 2023 via email

@juliocc
Copy link
Collaborator

juliocc commented Jun 29, 2023

Sorry, I didn't explain myself clearly.

Let's make sure DP and GKE use the same ranges in all networking stages.

For DP we want (@lcaggio can you LGTM these ranges?):

  • Primary range: 100.127.48.0/24 (unchanged)
  • Pods secondary range: 100.64.0.0/24 (was 100.64.48.0/20)
  • Services secondary range: 100.64.1.0/24 (was 100.64.64.0/24)

For GKE we want (@danielmarzini can you LGTM these ranges?):

  • Primary range: 100.127.49.0/24 (was 100.64.0.0/24)
  • Pods secondary range: 100.65.0.0/24 (was 100.64.0.0/16)
  • Services secondary range: 100.65.1.0/24 (wass 192.168.1.0/16)

This means updating the following subnets with the ranges above:

  • 2-networking-a-peering dev-dataplatform-ew1.yaml
  • 2-networking-a-peering dev-gke-nodes-ew1.yaml
  • 2-networking-b-vpn dev-dataplatform-ew1.yaml
  • 2-networking-b-vpn dev-gke-nodes-ew1.yaml
  • 2-networking-c-nva dev-dataplatform-ew1.yaml
  • 2-networking-d-separate-envs dev-dataplatform-ew1.yaml
  • 2-networking-e-nva-btp dev-dataplatform-ew1.yaml

Stages c, d, and e don't have the GKE subnet. We'll track that in #1481

@simonebruzzechesse @sruffilli can you quickly make sure these ranges are ok in your net stages?

@arvindag07 arvindag07 force-pushed the ip-conflict-remove branch from d48a638 to d3e4864 Compare June 29, 2023 16:25
@arvindag07
Copy link
Contributor Author

Thanks for the detailed comment. Made all the suggested changes as mentioned in #1477 (comment). Please review

@juliocc juliocc enabled auto-merge June 29, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAST: IPAM conflict between GKE and dataplatform dev subnets
2 participants