data-platform-minimal - support web_server_network_access_control #1474

kthhrv · 2023-06-28T13:01:21Z

enable setting of composer web server network access control

juliocc

Looks great, thanks!

Check my suggestions below.

blueprints/data-solutions/data-platform-minimal/variables.tf

kthhrv · 2023-06-29T08:50:47Z

still need to refactor the for_each content

juliocc

@kthhrv are you ready to merge this? This looks goods to me.

kthhrv · 2023-06-29T11:04:48Z

I've broken my local dev/test environment by rebasing to latest master, would like to get that working again to finishing my testing of this change before merging, thanks

kthhrv · 2023-06-29T15:13:10Z

ok got my dev env working again, one possible issue:

initial apply without web_server_access_control set, web server is public as expected
now apply with web_server_access_control set and the web server access is restricted to the supplied CIDRs
now apply with web_server_access_control not set again and no changes are made, ie access is still restricted

this doesn't feel like the correct behaviour to me hence why I was setting the variable default to composers own default of public.

happy to merge as is, your call, thanks

juliocc · 2023-06-29T15:57:34Z

now apply with web_server_access_control not set again and no changes are made, ie access is still restricted

I'd say this is a provider issue. Can you paste the diff/plan?

kthhrv · 2023-06-29T16:06:53Z

here is the output of the 3rd apply

~/ws/fast-03-data-platform-prod$ tf apply
module.data-platform.module.cur-project.google_project.project[0]: Refreshing state... [id=projects/tosbx-prod-dt-cur]
module.data-platform.module.processing-project.google_project.project[0]: Refreshing state... [id=projects/tosbx-prod-dt-prc]
module.data-platform.module.land-project.google_project.project[0]: Refreshing state... [id=projects/tosbx-prod-dt-lnd]
module.data-platform.module.common-project.google_project.project[0]: Refreshing state... [id=projects/tosbx-prod-dt-cmn]
module.data-platform.module.common-project.google_project_service.project_services["serviceusage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cmn/serviceusage.googleapis.com]
module.data-platform.module.common-project.google_project_service.project_services["dlp.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cmn/dlp.googleapis.com]
module.data-platform.module.common-project.google_project_service.project_services["stackdriver.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cmn/stackdriver.googleapis.com]
module.data-platform.module.common-project.google_project_service.project_services["iam.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cmn/iam.googleapis.com]
module.data-platform.module.common-project.google_project_service.project_services["datacatalog.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cmn/datacatalog.googleapis.com]
module.data-platform.module.common-project.google_project_service.project_services["cloudresourcemanager.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cmn/cloudresourcemanager.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["storage-component.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/storage-component.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["stackdriver.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/stackdriver.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["composer.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/composer.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["bigquerystorage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/bigquerystorage.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["serviceusage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/serviceusage.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["cloudkms.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/cloudkms.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["servicenetworking.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/servicenetworking.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["bigquery.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/bigquery.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["iam.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/iam.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["bigqueryreservation.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/bigqueryreservation.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["cloudresourcemanager.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/cloudresourcemanager.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["dataproc.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/dataproc.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["container.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/container.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["dataflow.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/dataflow.googleapis.com]
module.data-platform.module.processing-project.google_compute_shared_vpc_service_project.shared_vpc_service[0]: Refreshing state... [id=tosbx-prod-net-spoke-0/tosbx-prod-dt-prc]
module.data-platform.module.cur-project.google_project_service.project_services["iam.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/iam.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["compute.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/compute.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["serviceusage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/serviceusage.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["compute.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/compute.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["cloudresourcemanager.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/cloudresourcemanager.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["bigqueryreservation.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/bigqueryreservation.googleapis.com]
module.data-platform.module.processing-project.google_project_service.project_services["storage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-prc/storage.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["stackdriver.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/stackdriver.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["bigquerystorage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/bigquerystorage.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["storage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/storage.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["bigquery.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/bigquery.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["cloudkms.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/cloudkms.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["storage-component.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/storage-component.googleapis.com]
module.data-platform.module.cur-project.google_project_service.project_services["servicenetworking.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-cur/servicenetworking.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["bigquery.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/bigquery.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["storage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/storage.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["serviceusage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/serviceusage.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["stackdriver.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/stackdriver.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["storage-component.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/storage-component.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["bigqueryreservation.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/bigqueryreservation.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["cloudkms.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/cloudkms.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["bigquerystorage.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/bigquerystorage.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["iam.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/iam.googleapis.com]
module.data-platform.module.land-project.google_project_service.project_services["cloudresourcemanager.googleapis.com"]: Refreshing state... [id=tosbx-prod-dt-lnd/cloudresourcemanager.googleapis.com]
module.data-platform.module.processing-project.data.google_storage_project_service_account.gcs_sa[0]: Reading...
module.data-platform.module.processing-project.data.google_bigquery_default_service_account.bq_sa[0]: Reading...
module.data-platform.module.cur-project.google_project_service_identity.servicenetworking[0]: Refreshing state... [id=projects/tosbx-prod-dt-cur/services/servicenetworking.googleapis.com]
module.data-platform.module.processing-project.google_project_service_identity.servicenetworking[0]: Refreshing state... [id=projects/tosbx-prod-dt-prc/services/servicenetworking.googleapis.com]
module.data-platform.module.cur-project.data.google_storage_project_service_account.gcs_sa[0]: Reading...
module.data-platform.module.cur-project.data.google_bigquery_default_service_account.bq_sa[0]: Reading...
module.data-platform.module.common-datacatalog.google_data_catalog_taxonomy.default: Refreshing state... [id=projects/tosbx-prod-dt-cmn/locations/eu/taxonomies/8690897363005152116]
module.data-platform.module.processing-project.google_project_iam_member.servicenetworking[0]: Refreshing state... [id=tosbx-prod-dt-prc/roles/servicenetworking.serviceAgent/serviceAccount:[email protected]]
module.data-platform.module.cur-project.google_project_iam_member.servicenetworking[0]: Refreshing state... [id=tosbx-prod-dt-cur/roles/servicenetworking.serviceAgent/serviceAccount:[email protected]]
module.data-platform.module.cur-project.data.google_storage_project_service_account.gcs_sa[0]: Read complete after 0s [id=[email protected]]
module.data-platform.module.processing-project.data.google_storage_project_service_account.gcs_sa[0]: Read complete after 0s [id=[email protected]]
module.data-platform.module.common-datacatalog.google_data_catalog_policy_tag.default["3_Confidential"]: Refreshing state... [id=projects/tosbx-prod-dt-cmn/locations/eu/taxonomies/8690897363005152116/policyTags/8510401906131669078]
module.data-platform.module.common-datacatalog.google_data_catalog_policy_tag.default["2_Private"]: Refreshing state... [id=projects/tosbx-prod-dt-cmn/locations/eu/taxonomies/8690897363005152116/policyTags/1807636667494686715]
module.data-platform.module.common-datacatalog.google_data_catalog_policy_tag.default["1_Sensitive"]: Refreshing state... [id=projects/tosbx-prod-dt-cmn/locations/eu/taxonomies/8690897363005152116/policyTags/2935122188501596687]
module.data-platform.module.processing-project.data.google_bigquery_default_service_account.bq_sa[0]: Read complete after 0s [id=[email protected]]
module.data-platform.module.processing-project.google_project_iam_member.shared_vpc_host_robots["roles/compute.networkUser:cloudservices"]: Refreshing state... [id=tosbx-prod-net-spoke-0/roles/compute.networkUser/serviceAccount:[email protected]]
module.data-platform.module.processing-project.google_project_iam_member.shared_vpc_host_robots["roles/compute.networkUser:container-engine"]: Refreshing state... [id=tosbx-prod-net-spoke-0/roles/compute.networkUser/serviceAccount:service-922934110375@container-engine-robot.iam.gserviceaccount.com]
module.data-platform.module.processing-project.google_project_iam_member.shared_vpc_host_robots["roles/container.hostServiceAgentUser:container-engine"]: Refreshing state... [id=tosbx-prod-net-spoke-0/roles/container.hostServiceAgentUser/serviceAccount:service-922934110375@container-engine-robot.iam.gserviceaccount.com]
module.data-platform.module.processing-project.google_project_iam_member.shared_vpc_host_robots["roles/compute.networkUser:compute"]: Refreshing state... [id=tosbx-prod-net-spoke-0/roles/compute.networkUser/serviceAccount:[email protected]]
module.data-platform.module.processing-project.google_project_iam_member.shared_vpc_host_robots["roles/compute.networkUser:dataproc"]: Refreshing state... [id=tosbx-prod-net-spoke-0/roles/compute.networkUser/serviceAccount:[email protected]]
module.data-platform.module.cur-project.data.google_bigquery_default_service_account.bq_sa[0]: Read complete after 0s [id=[email protected]]
module.data-platform.module.processing-project.google_project_iam_member.shared_vpc_host_robots["roles/compute.networkUser:dataflow"]: Refreshing state... [id=tosbx-prod-net-spoke-0/roles/compute.networkUser/serviceAccount:service-922934110375@dataflow-service-producer-prod.iam.gserviceaccount.com]
module.data-platform.module.processing-project.google_project_iam_member.shared_vpc_host_robots["roles/composer.sharedVpcAgent:composer"]: Refreshing state... [id=tosbx-prod-net-spoke-0/roles/composer.sharedVpcAgent/serviceAccount:service-922934110375@cloudcomposer-accounts.iam.gserviceaccount.com]
module.data-platform.module.cur-sa-0.google_service_account.service_account[0]: Refreshing state... [id=projects/tosbx-prod-dt-cur/serviceAccounts/[email protected]]
module.data-platform.module.cur-bq-0.google_bigquery_dataset.default: Refreshing state... [id=projects/tosbx-prod-dt-cur/datasets/tosbx_prod_dt_cur_bq_0]
module.data-platform.module.cur-cs-0.google_storage_bucket.bucket: Refreshing state... [id=tosbx-prod-dt-cur-cs-0]
module.data-platform.module.cur-sa-0.google_service_account_iam_binding.roles["roles/iam.serviceAccountTokenCreator"]: Refreshing state... [id=projects/tosbx-prod-dt-cur/serviceAccounts/[email protected]/roles/iam.serviceAccountTokenCreator]
module.data-platform.module.processing-sa-0.google_service_account.service_account[0]: Refreshing state... [id=projects/tosbx-prod-dt-prc/serviceAccounts/[email protected]]
module.data-platform.module.processing-sa-cmp-0.google_service_account.service_account[0]: Refreshing state... [id=projects/tosbx-prod-dt-prc/serviceAccounts/tosbx-prod-dt-prc-cmp-0@tosbx-prod-dt-prc.iam.gserviceaccount.com]
module.data-platform.module.processing-cs-0.google_storage_bucket.bucket: Refreshing state... [id=tosbx-prod-dt-prc-cs-0]
module.data-platform.module.processing-temp-0.google_storage_bucket.bucket: Refreshing state... [id=tosbx-prod-dt-prc-tmp-0]
module.data-platform.module.processing-staging-0.google_storage_bucket.bucket: Refreshing state... [id=tosbx-prod-dt-prc-stg-0]
module.data-platform.module.processing-log-0.google_storage_bucket.bucket: Refreshing state... [id=tosbx-prod-dt-prc-log-0]
module.data-platform.module.cur-project.google_project_iam_binding.authoritative["roles/storage.objectViewer"]: Refreshing state... [id=tosbx-prod-dt-cur/roles/storage.objectViewer]
module.data-platform.module.cur-project.google_project_iam_binding.authoritative["roles/bigquery.dataOwner"]: Refreshing state... [id=tosbx-prod-dt-cur/roles/bigquery.dataOwner]
module.data-platform.module.cur-project.google_project_iam_binding.authoritative["roles/datacatalog.viewer"]: Refreshing state... [id=tosbx-prod-dt-cur/roles/datacatalog.viewer]
module.data-platform.module.cur-project.google_project_iam_binding.authoritative["roles/bigquery.dataViewer"]: Refreshing state... [id=tosbx-prod-dt-cur/roles/bigquery.dataViewer]
module.data-platform.module.cur-project.google_project_iam_binding.authoritative["roles/datacatalog.tagTemplateViewer"]: Refreshing state... [id=tosbx-prod-dt-cur/roles/datacatalog.tagTemplateViewer]
module.data-platform.module.cur-project.google_project_iam_binding.authoritative["roles/storage.objectAdmin"]: Refreshing state... [id=tosbx-prod-dt-cur/roles/storage.objectAdmin]
module.data-platform.module.cur-project.google_project_iam_binding.authoritative["roles/bigquery.jobUser"]: Refreshing state... [id=tosbx-prod-dt-cur/roles/bigquery.jobUser]
module.data-platform.module.common-project.google_project_iam_binding.authoritative["roles/datacatalog.admin"]: Refreshing state... [id=tosbx-prod-dt-cmn/roles/datacatalog.admin]
module.data-platform.module.common-project.google_project_iam_binding.authoritative["roles/dlp.admin"]: Refreshing state... [id=tosbx-prod-dt-cmn/roles/dlp.admin]
module.data-platform.module.common-project.google_project_iam_binding.authoritative["roles/dlp.reader"]: Refreshing state... [id=tosbx-prod-dt-cmn/roles/dlp.reader]
module.data-platform.module.common-project.google_project_iam_binding.authoritative["roles/dlp.estimatesAdmin"]: Refreshing state... [id=tosbx-prod-dt-cmn/roles/dlp.estimatesAdmin]
module.data-platform.module.common-project.google_project_iam_binding.authoritative["roles/datacatalog.categoryFineGrainedReader"]: Refreshing state... [id=tosbx-prod-dt-cmn/roles/datacatalog.categoryFineGrainedReader]
module.data-platform.module.common-project.google_project_iam_binding.authoritative["roles/dlp.user"]: Refreshing state... [id=tosbx-prod-dt-cmn/roles/dlp.user]
module.data-platform.module.common-project.google_project_iam_binding.authoritative["roles/datacatalog.viewer"]: Refreshing state... [id=tosbx-prod-dt-cmn/roles/datacatalog.viewer]
module.data-platform.module.land-project.data.google_storage_project_service_account.gcs_sa[0]: Reading...
module.data-platform.module.land-project.data.google_bigquery_default_service_account.bq_sa[0]: Reading...
module.data-platform.module.processing-sa-0.google_service_account_iam_binding.roles["roles/iam.serviceAccountUser"]: Refreshing state... [id=projects/tosbx-prod-dt-prc/serviceAccounts/[email protected]/roles/iam.serviceAccountUser]
module.data-platform.module.processing-sa-0.google_service_account_iam_binding.roles["roles/iam.serviceAccountTokenCreator"]: Refreshing state... [id=projects/tosbx-prod-dt-prc/serviceAccounts/[email protected]/roles/iam.serviceAccountTokenCreator]
module.data-platform.module.land-project.data.google_storage_project_service_account.gcs_sa[0]: Read complete after 0s [id=[email protected]]
module.data-platform.module.processing-sa-cmp-0.google_service_account_iam_binding.roles["roles/iam.serviceAccountTokenCreator"]: Refreshing state... [id=projects/tosbx-prod-dt-prc/serviceAccounts/tosbx-prod-dt-prc-cmp-0@tosbx-prod-dt-prc.iam.gserviceaccount.com/roles/iam.serviceAccountTokenCreator]
module.data-platform.module.land-project.data.google_bigquery_default_service_account.bq_sa[0]: Read complete after 0s [id=[email protected]]
module.data-platform.module.processing-sa-cmp-0.google_service_account_iam_binding.roles["roles/iam.serviceAccountUser"]: Refreshing state... [id=projects/tosbx-prod-dt-prc/serviceAccounts/tosbx-prod-dt-prc-cmp-0@tosbx-prod-dt-prc.iam.gserviceaccount.com/roles/iam.serviceAccountUser]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/composer.admin"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/composer.admin]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/iap.httpsResourceAccessor"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/iap.httpsResourceAccessor]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/dataflow.admin"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/dataflow.admin]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/storage.admin"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/storage.admin]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/serviceusage.serviceUsageConsumer"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/serviceusage.serviceUsageConsumer]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/composer.worker"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/composer.worker]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/dataflow.worker"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/dataflow.worker]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/dataproc.editor"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/dataproc.editor]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/bigquery.jobUser"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/bigquery.jobUser]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/composer.environmentAndStorageObjectAdmin"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/composer.environmentAndStorageObjectAdmin]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/dataproc.worker"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/dataproc.worker]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/iam.serviceAccountUser"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/iam.serviceAccountUser]
module.data-platform.module.processing-project.google_project_iam_binding.authoritative["roles/composer.ServiceAgentV2Ext"]: Refreshing state... [id=tosbx-prod-dt-prc/roles/composer.ServiceAgentV2Ext]
module.data-platform.module.land-cs-0.google_storage_bucket.bucket: Refreshing state... [id=tosbx-prod-dt-lnd-cs-0]
module.data-platform.module.land-sa-0.google_service_account.service_account[0]: Refreshing state... [id=projects/tosbx-prod-dt-lnd/serviceAccounts/[email protected]]
module.data-platform.module.land-bq-0.google_bigquery_dataset.default: Refreshing state... [id=projects/tosbx-prod-dt-lnd/datasets/tosbx_prod_dt_lnd_bq_0]
module.data-platform.module.land-sa-0.google_service_account_iam_binding.roles["roles/iam.serviceAccountTokenCreator"]: Refreshing state... [id=projects/tosbx-prod-dt-lnd/serviceAccounts/[email protected]/roles/iam.serviceAccountTokenCreator]
module.data-platform.module.land-project.google_project_iam_binding.authoritative["roles/storage.objectAdmin"]: Refreshing state... [id=tosbx-prod-dt-lnd/roles/storage.objectAdmin]
module.data-platform.module.land-project.google_project_iam_binding.authoritative["roles/storage.objectCreator"]: Refreshing state... [id=tosbx-prod-dt-lnd/roles/storage.objectCreator]
module.data-platform.module.land-project.google_project_iam_binding.authoritative["roles/storage.objectViewer"]: Refreshing state... [id=tosbx-prod-dt-lnd/roles/storage.objectViewer]
module.data-platform.google_composer_environment.processing-cmp-0[0]: Refreshing state... [id=projects/tosbx-prod-dt-prc/locations/europe-west1/environments/tosbx-prod-dt-prc-cmp-0]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so
no changes are needed.
╷
│ Warning: Value for undeclared variable
│
│ The root module does not declare a variable named "service_accounts" but a value was found in file
│ "1-resman.auto.tfvars.json". If you meant to use this value, add a "variable" block to the
│ configuration.
│
│ To silence these warnings, use TF_VAR_... environment variables to provide certain "global" settings
│ to all configurations in your organization. To reduce the verbosity of these warnings, use the
│ -compact-warnings option.
╵
╷
│ Warning: Value for undeclared variable
│
│ The root module does not declare a variable named "locations" but a value was found in file
│ "globals.auto.tfvars.json". If you meant to use this value, add a "variable" block to the
│ configuration.
│
│ To silence these warnings, use TF_VAR_... environment variables to provide certain "global" settings
│ to all configurations in your organization. To reduce the verbosity of these warnings, use the
│ -compact-warnings option.
╵
╷
│ Warning: Values for undeclared variables
│
│ In addition to the other similar warnings shown, 10 other variable(s) defined without being declared.
╵

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

kthhrv · 2023-06-29T16:13:33Z

@juliocc I'm new to TF and GCP so please excuse my lack of knowledge :) BTW I'm just using a temporary Sandbox organisation to learn and develop our IoC before deploying in anger to our real GCP Org

juliocc · 2023-06-29T16:18:30Z

@juliocc I'm new to TF and GCP so please excuse my lack of knowledge :) BTW I'm just using a temporary Sandbox organisation to learn and develop our IoC before deploying in anger to our real GCP Org

That output is fine. IMO the module and terraform are WAI.

I'll go ahead and merge like this.

kthhrv · 2023-06-29T16:20:56Z

Thanks! "WAI"?

wiktorn · 2023-06-29T16:22:02Z

"WAI"?

Works As Intended :-)

juliocc · 2023-06-29T16:23:26Z

"WAI"?

Works As Intended :-)

Exactly! We like our TLAs ;)

kthhrv · 2023-06-29T16:30:17Z

this looks like someone having the same issue with composer not reverting to default if CIDRs aren't supplied
https://discuss.hashicorp.com/t/unable-to-remove-resource-attribute-that-was-provisioned-with-terraform/24701
this is bug with the provider module?

kthhrv added 3 commits June 28, 2023 13:28

data-platform-minimal - support web_server_network_access_control

7cd9083

Update variables.tf

b30efa8

Update 02-composer.tf

9e8323b

github-actions bot added the on:blueprints label Jun 28, 2023

kthhrv added 2 commits June 28, 2023 14:06

lint

f9742c5

more linting

52ad1fe

juliocc requested changes Jun 28, 2023

View reviewed changes

blueprints/data-solutions/data-platform-minimal/variables.tf Outdated Show resolved Hide resolved

change var name, drop default, update docs

e3e0554

kthhrv added 3 commits June 29, 2023 09:55

default to empty map

f15e2f3

use key/value and update docs

912497a

Merge branch 'master' into kthhrv-patch-1

b203198

juliocc approved these changes Jun 29, 2023

View reviewed changes

Merge branch 'master' into kthhrv-patch-1

0bd3f5a

juliocc merged commit f0fbc14 into GoogleCloudPlatform:master Jun 29, 2023

kthhrv deleted the kthhrv-patch-1 branch June 29, 2023 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

data-platform-minimal - support web_server_network_access_control #1474

data-platform-minimal - support web_server_network_access_control #1474

kthhrv commented Jun 28, 2023 •

edited

Loading

juliocc left a comment

kthhrv commented Jun 29, 2023

juliocc left a comment

kthhrv commented Jun 29, 2023

kthhrv commented Jun 29, 2023

juliocc commented Jun 29, 2023

kthhrv commented Jun 29, 2023

kthhrv commented Jun 29, 2023 •

edited

Loading

juliocc commented Jun 29, 2023

kthhrv commented Jun 29, 2023

wiktorn commented Jun 29, 2023

juliocc commented Jun 29, 2023 •

edited

Loading

kthhrv commented Jun 29, 2023

data-platform-minimal - support web_server_network_access_control #1474

data-platform-minimal - support web_server_network_access_control #1474

Conversation

kthhrv commented Jun 28, 2023 • edited Loading

juliocc left a comment

Choose a reason for hiding this comment

kthhrv commented Jun 29, 2023

juliocc left a comment

Choose a reason for hiding this comment

kthhrv commented Jun 29, 2023

kthhrv commented Jun 29, 2023

juliocc commented Jun 29, 2023

kthhrv commented Jun 29, 2023

kthhrv commented Jun 29, 2023 • edited Loading

juliocc commented Jun 29, 2023

kthhrv commented Jun 29, 2023

wiktorn commented Jun 29, 2023

juliocc commented Jun 29, 2023 • edited Loading

kthhrv commented Jun 29, 2023

kthhrv commented Jun 28, 2023 •

edited

Loading

kthhrv commented Jun 29, 2023 •

edited

Loading

juliocc commented Jun 29, 2023 •

edited

Loading