Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename network load balancer modules #1466

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Rename network load balancer modules #1466

merged 9 commits into from
Jun 26, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jun 23, 2023

@ludoo ludoo requested a review from juliocc June 23, 2023 16:45
@ludoo ludoo requested a review from sruffilli June 23, 2023 16:46
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Jun 23, 2023
@ludoo ludoo enabled auto-merge (squash) June 23, 2023 17:03
@sruffilli
Copy link
Collaborator

There are still quite a few instances where "ILB" and "GLB" are referred to, mostly as descriptions or module names.
https://gist.github.com/sruffilli/fb617854cf1ef5a632f5312943fc3233

I guess we're ok with that - just making sure.

@ludoo
Copy link
Collaborator Author

ludoo commented Jun 24, 2023

Yep this is only the code part. READMEs will take a bit more care and can be done incrementally imho.

@sruffilli
Copy link
Collaborator

LGTM with some additional changes which can be postponed
https://gist.github.com/sruffilli/6f7d35c15cc907326e5ffbad637a09e0

juliocc
juliocc approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more instances of the old names but let's merge this PR and we update the rest as we go along

@ludoo ludoo merged commit 638841c into master Jun 26, 2023
@ludoo ludoo deleted the ludo/lb-rename-2 branch June 26, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruffilli sruffilli sruffilli approved these changes

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints on:documentation on:FAST on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludoo @sruffilli @juliocc