Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match readme groups with variables file in shielded folder blueprint #1455

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

CanburakTumer
Copy link
Contributor

I faced error during my deployment even though I created data-engineers group. Then I found out that variables file uses gcp-data-engineers as default. The same is valid for data-security.

reference lines in variables.tf:

workload-engineers = optional(string, "gcp-data-engineers")

workload-security = optional(string, "gcp-data-security")

I faced error during my deployment even though I created data-engineers group. Then I found out that variables file uses gcp-data-engineers as default. The same is valid for data-security.
@ludoo ludoo marked this pull request as ready for review June 21, 2023 09:50
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@ludoo ludoo merged commit adc1ff3 into GoogleCloudPlatform:master Jun 21, 2023
@CanburakTumer CanburakTumer deleted the fix-readme branch June 21, 2023 09:54
@ludoo ludoo changed the title match readme groups with variables file Match readme groups with variables file in shielded folder blueprint Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants