Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom tag support to FAST #1426

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Add custom tag support to FAST #1426

merged 5 commits into from
Jun 7, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jun 7, 2023

This adds support for a custom tag hierarchy to FAST stage 1, and includes simple aliasing to refer to the internally created IaC service accounts in tag value bindings.

tags = {
  org-policies = {
    description = "Tag values used in organization policy conditions."
    values = {
      drs-allow-all = {
        description = "Allow all in Domain Restricted Sharing."
        iam = {
          "roles/resourcemanager.tagUser" = ["sandbox"]
        }
      }
    }
  }
}

It also creates a new tag key that forms the base of the hierarchy of tag values for org policy conditions. This has a single default value for "DRS all" but can be extended by using the same tag key name in the custom variable shown above.

@ludoo ludoo requested a review from juliocc June 7, 2023 21:08
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@ludoo ludoo requested a review from juliocc June 7, 2023 21:56
@ludoo ludoo enabled auto-merge (squash) June 7, 2023 22:00
@ludoo ludoo merged commit c024eca into master Jun 7, 2023
@ludoo ludoo deleted the ludo/fast-tags branch June 7, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants