Move net-dedicated-vlan-attachment module to net-vlan-attachment and …

[apichick]

…added support for Partner interconnect

[sruffilli]

Two general comments:

1. (my ignorance) I'm unclear about what happens when creating a partner interconnect via terraform, and whether the "pending"-state vlan attachment can be used ad a resource. If not, everything that depends on those VLAN attachment would fail (I'm especially thinking about the blueprint here)
2. Before merging we need to test these changes in the real world :( unfortunately while I've had the chance to test a dedicated interconnect, testing a partner interconnect involves external stakeholders and I'm not sure we'll be able to test it internally.

Besides that, good job!

[wiktorn]

Two general comments:

1. (my ignorance) I'm unclear about what happens when creating a partner interconnect via terraform, and whether the "pending"-state vlan attachment can be used ad a resource. If not, everything that depends on those VLAN attachment would fail (I'm especially thinking about the blueprint here)

I just tested. After creating the attachment it looks as follows:

$ terraform state show 'module.example-va.google_compute_interconnect_attachment.default'
# module.example-va.google_compute_interconnect_attachment.default:
resource "google_compute_interconnect_attachment" "default" {
    admin_enabled             = true
    creation_timestamp        = "2023-06-07T05:34:31.372-07:00"
    description               = "Example vlan attachment"
    edge_availability_domain  = "AVAILABILITY_DOMAIN_ANY"
    encryption                = "NONE"
    id                        = "projects/***/regions/europe-west1/interconnectAttachments/vlan-attachment"
    ipsec_internal_addresses  = []
    mtu                       = "1500"
    name                      = "vlan-attachment"
    pairing_key               = "***/europe-west1/any"
    private_interconnect_info = []
    project                   = "***"
    region                    = "https://www.googleapis.com/compute/v1/projects/***/regions/europe-west1"
    router                    = "https://www.googleapis.com/compute/v1/projects/***/regions/europe-west1/routers/interconnect-router"
    self_link                 = "https://www.googleapis.com/compute/v1/projects/***/regions/europe-west1/interconnectAttachments/vlan-attachment"
    state                     = "PENDING_PARTNER"
    type                      = "PARTNER"
    vlan_tag8021q             = 0
}

Looks like perfectly usable for use as reference in other resources and the blueprint should be fine.

2. Before merging we need to test these changes in the real world :( unfortunately while I've had the chance to test a dedicated interconnect, testing a partner interconnect involves external stakeholders and I'm not sure we'll be able to test it internally.

Agreed. Though I think we can test quite a lot even without having access to test partner interconnect to iron this out.