Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve GCS2BQ blueprint #1416

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Fix and improve GCS2BQ blueprint #1416

merged 5 commits into from
Jun 6, 2023

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented Jun 5, 2023

In this PR I improve the GCS2BQ blueprint.

  • Fix roles
  • Implement Shared VPC roles relying on project service_identity_iam variable
  • Group project variable into project_config variable
  • Rely on optional variables to avoid try()

@lcaggio lcaggio marked this pull request as ready for review June 5, 2023 07:10
@lcaggio lcaggio requested a review from juliocc June 5, 2023 07:10
@lcaggio lcaggio merged commit 7ed197a into master Jun 6, 2023
@lcaggio lcaggio deleted the lcaggio/gcs2bq-fixes branch June 6, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcaggio @wiktorn