-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VPN monitoring alerts to 2-networking and VPN usage chart #1412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice, thanks Ana! The problem with networking stages is, this should be rolled out to all other stages too :(
@afda16 We have a check to ensure the peering and VPN stages are identical except for a few resources. To make the tests pass you'll have to replicate the same change in the peering stage. In fact, I think it makes sense to have this in all networking stages with VPNs. |
d0a862f
to
9e32a86
Compare
Thanks @juliocc , I'll add it to the rest of networking stages |
c03c58d
to
b34b989
Compare
6fb2e6c
to
e71ab7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was able to test the VPN.json dashboard and it works fine. I wasn't able to test the full solution in a fabric fast deployment though because I don't have one at hand right now.
The Fast stage 2-networking-* currently adds a monitoring dashboard for VPN metrics. This change adds an additional chart to monitor the usage of the VPN bandwidth. This change also adds the following monitoring alerts: * VPN tunnel established * [VPN bandwidth](https://cloud.google.com/network-connectivity/docs/vpn/how-to/viewing-logs-metrics#define-bandwidth-alerts) To configure the alerts, there is a new `alert_config` variable with defined default values. The alerts are created in the stage `b` by default. In the stages a, c, d, and e, the alerts are created if the user creates the On-prem VPN. To disable the creation of alerts, add the following to `terraform.tfvars`: ``` alert_config = { vpn_tunnel_established = null vpn_tunnel_bandwidth = null } ```
The Fast stage 2-networking-* currently adds a monitoring dashboard for VPN metrics. This change adds an additional chart to monitor the usage of the VPN bandwidth.
This change also adds the following monitoring alerts:
To configure the alerts, there is a new
alert_config
variable with defined default values.The alerts are created in the stage
b
by default. In the stages a, c, d, and e, the alerts are created if the user creates the On-prem VPN.To disable the creation of alerts, add the following to
terraform.tfvars
: