Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPN monitoring alerts to 2-networking and VPN usage chart #1412

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

afda16
Copy link
Collaborator

@afda16 afda16 commented Jun 2, 2023

The Fast stage 2-networking-* currently adds a monitoring dashboard for VPN metrics. This change adds an additional chart to monitor the usage of the VPN bandwidth.

This change also adds the following monitoring alerts:

To configure the alerts, there is a new alert_config variable with defined default values.

The alerts are created in the stage b by default. In the stages a, c, d, and e, the alerts are created if the user creates the On-prem VPN.

To disable the creation of alerts, add the following to terraform.tfvars:

alert_config = {
  vpn_tunnel_established = null
  vpn_tunnel_bandwidth = null
}

@afda16 afda16 requested review from ludoo and aurelienlegrand June 2, 2023 15:06
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, thanks Ana! The problem with networking stages is, this should be rolled out to all other stages too :(

fast/stages/2-networking-b-vpn/variables.tf Outdated Show resolved Hide resolved
@juliocc
Copy link
Collaborator

juliocc commented Jun 2, 2023

@afda16 We have a check to ensure the peering and VPN stages are identical except for a few resources. To make the tests pass you'll have to replicate the same change in the peering stage. In fact, I think it makes sense to have this in all networking stages with VPNs.

@afda16 afda16 force-pushed the afda16/vpn-alerts branch 3 times, most recently from d0a862f to 9e32a86 Compare June 2, 2023 15:34
@afda16
Copy link
Collaborator Author

afda16 commented Jun 2, 2023

Thanks @juliocc , I'll add it to the rest of networking stages

@afda16 afda16 changed the title Add VPN monitoring alerts to 2-networking-b-vpn [Draft] Add VPN monitoring alerts to 2-networking-b-vpn Jun 2, 2023
@afda16 afda16 force-pushed the afda16/vpn-alerts branch 2 times, most recently from c03c58d to b34b989 Compare June 5, 2023 14:43
@afda16 afda16 changed the title [Draft] Add VPN monitoring alerts to 2-networking-b-vpn [Draft] Add VPN monitoring alerts to 2-networking and VPN usage chart Jun 5, 2023
@afda16 afda16 force-pushed the afda16/vpn-alerts branch 6 times, most recently from 6fb2e6c to e71ab7b Compare June 5, 2023 15:14
Copy link
Collaborator

@aurelienlegrand aurelienlegrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I was able to test the VPN.json dashboard and it works fine. I wasn't able to test the full solution in a fabric fast deployment though because I don't have one at hand right now.

@afda16 afda16 changed the title [Draft] Add VPN monitoring alerts to 2-networking and VPN usage chart Add VPN monitoring alerts to 2-networking and VPN usage chart Jun 6, 2023
@afda16 afda16 force-pushed the afda16/vpn-alerts branch from e71ab7b to 853c63e Compare June 6, 2023 12:08
The Fast stage 2-networking-* currently adds a monitoring dashboard
for VPN metrics. This change adds an additional chart to monitor the
usage of the VPN bandwidth.

This change also adds the following monitoring alerts:

* VPN tunnel established
*
[VPN bandwidth](https://cloud.google.com/network-connectivity/docs/vpn/how-to/viewing-logs-metrics#define-bandwidth-alerts)

To configure the alerts, there is a new `alert_config` variable with
defined default values.

The alerts are created in the stage `b` by default. In the stages a,
c, d, and e, the alerts are created if the user creates the On-prem
VPN.

To disable the creation of alerts, add the following to
`terraform.tfvars`:

```
alert_config = {
  vpn_tunnel_established = null
  vpn_tunnel_bandwidth = null
}
```
@afda16 afda16 force-pushed the afda16/vpn-alerts branch from 853c63e to 0fe3f16 Compare June 6, 2023 12:49
@afda16 afda16 merged commit 4876161 into master Jun 6, 2023
@afda16 afda16 deleted the afda16/vpn-alerts branch June 6, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants