-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default googleapi route creation to net-vpc #1400
Conversation
268bb34
to
127fcd1
Compare
127fcd1
to
7a91a7e
Compare
c290b59
to
5da1790
Compare
All good just maybe change the var name? These are not default routes (in the networking sense). |
One more point, a bit more controversial. I see today we don't default to true delete_default_routes_on_create. We could consider also adding a TF managed "default" route in addition to these in the module (create_special_routes), or at least do that just for FAST. |
Good point. Can you open an issue for this? |
You're right, "default routes" is a terrible name. Any suggestions? |
5da1790
to
afdcea7
Compare
afdcea7
to
0888cce
Compare
No description provided.