Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to configure stack type in GKE autopilot #1395

Conversation

NitriKx
Copy link
Contributor

@NitriKx NitriKx commented May 24, 2023

No description provided.

@google-cla
Copy link

google-cla bot commented May 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented May 24, 2023

Thanks for this! Would you mind also doing the same for the standard GKE module?

@NitriKx NitriKx force-pushed the nitrikx/allow-configure-gke-stack-type branch 3 times, most recently from 1fd26a5 to 65100bc Compare May 24, 2023 09:53
@NitriKx NitriKx force-pushed the nitrikx/allow-configure-gke-stack-type branch from 65100bc to f1d1636 Compare May 24, 2023 09:56
@NitriKx NitriKx marked this pull request as ready for review May 24, 2023 09:58
@NitriKx
Copy link
Contributor Author

NitriKx commented May 24, 2023

Hello @ludoo, I've made the changes 👍

@ludoo
Copy link
Collaborator

ludoo commented May 24, 2023

Thanks a lot! setting this to auto-merge :)

@ludoo ludoo enabled auto-merge (squash) May 24, 2023 10:06
@ludoo ludoo merged commit aa80109 into GoogleCloudPlatform:master May 24, 2023
@NitriKx NitriKx deleted the nitrikx/allow-configure-gke-stack-type branch May 25, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants