Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditional org admin role to sandbox SA #1385

Merged
merged 2 commits into from
May 21, 2023
Merged

Add conditional org admin role to sandbox SA #1385

merged 2 commits into from
May 21, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented May 21, 2023

No description provided.

@ludoo ludoo requested a review from juliocc May 21, 2023 08:25
@ludoo ludoo merged commit e0911c6 into master May 21, 2023
@ludoo ludoo deleted the ludo/fast-sandbox-org-admin branch May 21, 2023 08:48
@gustavovalverde
Copy link
Contributor

gustavovalverde commented May 23, 2023 •
edited
Loading

I'm having an error after this change, when doing a terraform apply on 1-resman

│ Error: Invalid index
│ 
│   on branch-sandbox.tf line 68, in resource "google_organization_iam_member" "org_policy_admin_sandbox":
│   68:   member = module.branch-sandbox-sa.0.iam_email
│     ├────────────────
│     │ module.branch-sandbox-sa is empty tuple
│ 
│ The given key does not identify an element in this collection value: the collection has no elements.

Edit: Created this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludoo @gustavovalverde @juliocc