Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several updates #1375

Merged
merged 5 commits into from
May 15, 2023
Merged

Several updates #1375

merged 5 commits into from
May 15, 2023

Conversation

bluPhy
Copy link
Collaborator

@bluPhy bluPhy commented May 14, 2023

Several updates

@bluPhy
Several updates
87cd83f 
Several updates
juliocc
juliocc approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these fixes!

Can you ensure the linting test passes? I think you're modifying some of the input/output tables in the READMEs without updating the corresponding terraform file.

juliocc
juliocc approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these fixes!

Can you ensure the linting test passes? I think you're modifying some of the input/output tables in the READMEs without updating the corresponding terraform file.

@bluPhy
Copy link
Collaborator Author

bluPhy commented May 15, 2023 •
edited
Loading

@juliocc Spend some time trying to understand why the linting fails on just a few files were there is no changes to the variable names but in the comments or descriptions, at the end I could not get to the bottom of it. Decided to revert changes only to the problematic files to allow most of the changes to be committed and will work only on the problematic ones later.

@juliocc
Copy link
Collaborator

juliocc commented May 15, 2023 •
edited
Loading

@bluPhy I'm merging this. Can you open a PR with the remaining changes and I'll try to fix the linting issues?

@juliocc juliocc merged commit 5bd3aa4 into GoogleCloudPlatform:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:blueprints on:documentation on:FAST on:modules on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluPhy @juliocc