Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net-cloudnat): add toggle for independent endpoint mapping and dynamic port allocation #1365

Merged
merged 1 commit into from
May 12, 2023

Conversation

JSchwerberg
Copy link
Contributor

No description provided.

juliocc
juliocc previously approved these changes May 8, 2023
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

Can you update the README using tfdoc as explained in the contribution guide?

@JSchwerberg
Copy link
Contributor Author

@juliocc Done :)

@JSchwerberg
Copy link
Contributor Author

@juliocc slipping in some toggles for dynamic port allocation as well -- the current module is broken, with var.config_min_ports_per_vm being a no-op since dynamic port allocation isn't turned on by default. This fixes that, and adds a variable for config_max_ports_per_vm, as well as making sure that dynamic port allocation and independent endpoint mapping are mutually exclusive as required by the API.

@JSchwerberg JSchwerberg changed the title feat(net-cloudnat): add toggle for independent endpoint mapping feat(net-cloudnat): add toggle for independent endpoint mapping and dynamic port allocation May 10, 2023
@ludoo ludoo dismissed juliocc’s stale review May 10, 2023 21:03

extra changes require new review

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, also make sure all tests and linting checks are passing.

modules/net-cloudnat/variables.tf Outdated Show resolved Hide resolved
modules/net-cloudnat/outputs.tf Outdated Show resolved Hide resolved
modules/net-cloudnat/variables.tf Outdated Show resolved Hide resolved
@JSchwerberg JSchwerberg requested review from juliocc and ludoo May 10, 2023 21:14
@JSchwerberg
Copy link
Contributor Author

See inline comments, also make sure all tests and linting checks are passing.

I'd love to, but that would mean Github would have to fix their 6 hour plus actions outage, so we'll have to re-run whenever they get their act together 😁

modules/net-cloudnat/variables.tf Outdated Show resolved Hide resolved
modules/net-cloudnat/variables.tf Outdated Show resolved Hide resolved
@JSchwerberg
Copy link
Contributor Author

This is now passing linting and tests. Some test are failing on my machine locally, but are ENTIRELY unrelated to this PR and have to do with upstream changes in the firewall API, afaict.

cc @juliocc @ludoo

modules/net-cloudnat/variables.tf Outdated Show resolved Hide resolved
modules/net-cloudnat/variables.tf Show resolved Hide resolved
@juliocc juliocc merged commit b153474 into GoogleCloudPlatform:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants