-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(net-cloudnat): add toggle for independent endpoint mapping and dynamic port allocation #1365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
Can you update the README using tfdoc as explained in the contribution guide?
@juliocc Done :) |
@juliocc slipping in some toggles for dynamic port allocation as well -- the current module is broken, with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments, also make sure all tests and linting checks are passing.
I'd love to, but that would mean Github would have to fix their 6 hour plus actions outage, so we'll have to re-run whenever they get their act together 😁 |
No description provided.