Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate plan runner fixture and all its variants #1339

Merged
merged 11 commits into from
Apr 22, 2023
Merged

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Apr 21, 2023

Migrate remaining modules to the new testing framework

@juliocc juliocc requested a review from ludoo April 21, 2023 15:53
@juliocc juliocc enabled auto-merge April 21, 2023 15:54
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating the old runners is great, I'm just not sure we want to add inventory for everything: whenever the resource changes they break, and often you end up needing to remove stuff fromt he inventory, or figure out why some attribute changed. Happened twice to me lately and I lost a lot of time over something that was WAI.

@juliocc
Copy link
Collaborator Author

juliocc commented Apr 22, 2023

Deprecating the old runners is great, I'm just not sure we want to add inventory for everything: whenever the resource changes they break, and often you end up needing to remove stuff fromt he inventory, or figure out why some attribute changed. Happened twice to me lately and I lost a lot of time over something that was WAI.

Agreed. Most of the new inventories reflect what we were already testing using python assertions. I did add a few here and there but I tried to keep them simple and asserting only the critical bits.

We should definitely fix/remove/improve those cases where you find things WAI that are causing false positives.

@juliocc juliocc merged commit 2d76f80 into master Apr 22, 2023
@juliocc juliocc deleted the jccb/more-tests branch April 22, 2023 11:43
@ludoo ludoo added the on:tools New or changed tool label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on:tools New or changed tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants