-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate plan runner fixture and all its variants #1339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecating the old runners is great, I'm just not sure we want to add inventory for everything: whenever the resource changes they break, and often you end up needing to remove stuff fromt he inventory, or figure out why some attribute changed. Happened twice to me lately and I lost a lot of time over something that was WAI.
Agreed. Most of the new inventories reflect what we were already testing using python assertions. I did add a few here and there but I tried to keep them simple and asserting only the critical bits. We should definitely fix/remove/improve those cases where you find things WAI that are causing false positives. |
Migrate remaining modules to the new testing framework