Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate renewal through terraform #1336

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

bjohnrl
Copy link
Contributor

@bjohnrl bjohnrl commented Apr 18, 2023

When renewing the certificate by updating the variable file, GCP will not let you update because it will try to delete the old certificate is been used by the target proxy. Updating lifecycle with create_before_destroy will allow the certificate and attach to the proxy and then delete the old certificate.

@google-cla
Copy link

google-cla bot commented Apr 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Apr 18, 2023

hi @bjohnrl, thanks the patch. Can you run your code through terraform fmt and sign the CLA?

Thanks!

@juliocc juliocc merged commit df8c61f into GoogleCloudPlatform:master Apr 19, 2023
@juliocc
Copy link
Collaborator

juliocc commented Apr 19, 2023

The linting error is not related to your PR. I've force-merged and we'll fix the issue later.

Thanks @bjohnrl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants