Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change net-glb serve_while_stale type to number #1329

Merged
merged 4 commits into from
May 5, 2023

Conversation

tobbbles
Copy link
Contributor

In the provider, the serve_while_stale attribute is listed as an integer, https://github.com/hashicorp/terraform-provider-google/blob/main/google/resource_compute_backend_service.go#L373-L374

And also documented here as such: https://cloud.google.com/cdn/docs/serving-stale-content

Currently it is not possible to configure cdn_policy with this module and specify a serve_whilst_stale value.

@google-cla
Copy link

google-cla bot commented Apr 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Apr 17, 2023

thanks @tobbbles! good catch.

@ludoo ludoo enabled auto-merge (squash) April 19, 2023 06:00
@ludoo ludoo disabled auto-merge May 5, 2023 07:17
@ludoo ludoo enabled auto-merge (squash) May 5, 2023 07:18
@ludoo ludoo merged commit e333b6f into GoogleCloudPlatform:master May 5, 2023
lcaggio pushed a commit that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants