add firewall enforcement variable to VPC #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think there's a way yet to control this via Terraform. |
|
I think version 4.60 of the provider added support for this |
|
yes its available in version 4.60, but for some reason the checks are breaking this is why i closed the PR |
juliocc
requested changes
Apr 11, 2023
There was a problem hiding this comment.
- The provider is currently pinned to version 4.59. Can you update default-versions.tf and then run
find . -name versions.tf -exec cp default-versions.tf {} \;from the root of the repo to upgrade it? - Please add at least one test to ensure the new variable is working correctly.
- I also left a couple of comments in variables.tf and main.tf. Please take a look.
juliocc
approved these changes
Apr 11, 2023
|
Thanks for the PR and applying the requested changes @fawzihmouda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we can use both net-vpc-firewall-policy and net-vpc-firewall at the same time in a VPC, this PR will add the ability to choose the enforcement order for the Firewalls Policy
Default enforcement order is
AFTER_CLASSIC_FIREWALLhttps://cloud.google.com/vpc/docs/firewall-policies-overview#rule-evaluation