Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #1297

Merged
merged 6 commits into from
Apr 3, 2023
Merged

Update CONTRIBUTING.md #1297

merged 6 commits into from
Apr 3, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Apr 3, 2023

No description provided.

ludoo
ludoo approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add the other quote, where we discuss reducing the variable surface

ludoo
ludoo reviewed Apr 3, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
ludoo
ludoo approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline after 297 missing :)

@juliocc juliocc enabled auto-merge April 3, 2023 12:19
@juliocc juliocc merged commit 2e336bc into master Apr 3, 2023
@juliocc juliocc deleted the jccb/contrib-quotes branch April 3, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @ludoo