Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cloud run module to use optionals and support all features #1293

Merged
merged 18 commits into from
Apr 1, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Mar 29, 2023

Fixes #1290

@ludoo ludoo marked this pull request as ready for review April 1, 2023 06:45
@ludoo ludoo requested a review from juliocc April 1, 2023 06:45
modules/cloud-run/main.tf Show resolved Hide resolved
@ludoo ludoo merged commit 92b71a5 into master Apr 1, 2023
@ludoo ludoo deleted the ludo/cloud-run branch April 1, 2023 12:06
lcaggio pushed a commit that referenced this pull request May 5, 2023
…1293)

* refactor cloud run resource and variables

* vpc connector variables and resource

* refactor env variable, combine and fix env examples

* fix volume example

* fix traffic split example

* fix eventarc/pubsub example

* fix eventarc/audit log example

* fix SA examples, fix examples formatting

* refactor eventarc variable

* tfdoc

* add IAM to example

* add examples for revision annotations and serverless connector

* fix new examples

* remove legacy module tests

* blueprint tests

* Add tests to cloud-run module

---------

Co-authored-by: Julio Castillo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Cloud Run module
2 participants