Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for backup and remove deprecated control plane field in GKE module #1287

Merged
merged 11 commits into from
Mar 30, 2023
Merged

Add support for backup and remove deprecated control plane field in GKE module #1287

merged 11 commits into from
Mar 30, 2023

Conversation

valeriobponza
Copy link
Contributor

@valeriobponza valeriobponza commented Mar 28, 2023 •
edited by wiktorn
Loading

Incompatible change:

  • moving enable_addons.gke_backup_agent to backup_configs.enable_backup_agent in modules/gke-cluster

@wiktorn wiktorn added the incompatible change Pull request that breaks compatibility with previous version label Mar 28, 2023
@juliocc
Copy link
Collaborator

juliocc commented Mar 29, 2023

@valeriobponza we're in process of splitting and rewriting the GKE module as part of #1277. We can still go ahead with this PR but keep in mind some of this could end up being reimplemented/removed as part of that rewrite.

@valeriobponza
Copy link
Contributor Author

thank you @juliocc for pointing out. I made this changes on my local module for a demo and I thought it was low effort to share them. No biggie if they gets overwritten.

also, I would be happy to contribute to #1277 if there is still work to do!

@wiktorn wiktorn merged commit c5db50d into GoogleCloudPlatform:master Mar 30, 2023
@ludoo ludoo changed the title Add Backup for GKE plans support in GKE cluster module and removing deprecated control_plane field from GKE hub module Add support for backup and remove deprecated control plane field in GKE module Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
incompatible change Pull request that breaks compatibility with previous version on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valeriobponza @juliocc @wiktorn