Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique bundle name for Cloud Function #1281

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Mar 27, 2023

When cloud-function module is used multiple times within project and default bundle_config.output_path is used then all the instances try to use filename and result is undefined without guarantee to converge to desired state (i.e. multiple functions may share the same code).

When cloud-function module is used multiple times within project and
default `bundle_config.output_path` is used then all the instances try
to use filename and result is undefined without guarantee to converge to
desired state (i.e. multiple functions may share the same code).
@wiktorn wiktorn force-pushed the cloud_functions_non_conflicting_bundle branch from eb2e2cb to 9d04724 Compare March 27, 2023 07:55
modules/cloud-function/main.tf Outdated Show resolved Hide resolved
@juliocc
Copy link
Collaborator

juliocc commented Mar 27, 2023

When cloud-function module is used multiple times within project and default bundle_config.output_path is used then all the instances try to use filename and result is undefined without guarantee to converge to desired state (i.e. multiple functions may share the same code).

Can you add a test ensuring two calls to the module generate a different bundle path?

@wiktorn wiktorn force-pushed the cloud_functions_non_conflicting_bundle branch 3 times, most recently from 0f5d618 to 87118aa Compare March 27, 2023 10:50
@wiktorn wiktorn force-pushed the cloud_functions_non_conflicting_bundle branch from 87118aa to 16167c9 Compare March 27, 2023 11:42
@wiktorn wiktorn merged commit 9005a51 into GoogleCloudPlatform:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants