Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subnet sample yaml files to use subnet_secondary_ranges #1203

Merged

Conversation

jmound
Copy link
Contributor

@jmound jmound commented Mar 2, 2023

This change is a replace of secondary_ip_range: to secondary_ip_ranges: in the code samples and tests.

The net-vpc module's data_folder gets parsed expecting the form with the "s": secondary_ip_ranges:

secondary_ip_ranges = try(v.secondary_ip_ranges, null)

Testing:

  • A terraform apply using the secondary_ip_range: form causes no secondary ranges to be managed because of the try(..., null).
  • Using the plural form works as intended.

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test yaml files should be fine since the provider uses secondary_ip_range (without the s).

The factory files in the FAST networking stages indeed had to be fixed. Thanks for spotting this.

tests/modules/net_vpc/examples/factory.yaml Outdated Show resolved Hide resolved
@jmound jmound requested a review from juliocc March 2, 2023 16:40
@ludoo ludoo merged commit 4eff309 into GoogleCloudPlatform:master Mar 5, 2023
lcaggio pushed a commit that referenced this pull request May 5, 2023
* Replaces 'secondary_ip_range:' with 'secondary_ip_ranges:' in samples

* Replaces 'secondary_ip_range:' with 'secondary_ip_ranges:' in tests/

* reverts previous commit- files in tests/ don't need to be changed

---------

Co-authored-by: Ludovico Magnocavallo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants