Extended simple-nva module to manage BGP service running on FR routing docker container #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add optional run cmds during cloud init bootstrap add masquerading configuration on network interfaces variable skip route configuration when no LB is in front of the NVA
add bgp config for bgp server configuration on the nva via FRR container add optional run cmds to execute during cloud init bootstrap add condition to skip some rouiting configs when no LB is in front of the NVA
update documentation for simple-nva module
ludoo
approved these changes
Feb 28, 2023
LucaPrete
requested changes
Feb 28, 2023
There was a problem hiding this comment.
@simonebruzzechesse this is great. Thanks for submitting this. Just a few comments. Most of them are minor.
…output to static.
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
reviewed
Mar 7, 2023
LucaPrete
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major updates:
BGP is managed via FR Routing container running on the NVA, a default frr.conf file is provided (although not required with link to reference documentation).