Added a PSC GCLB example #1179
Merged
Added a PSC GCLB example #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of line comment
|
Can you add a basic test like other blueprints? Otherwise it will stop working as soon as we change one of its modules... |
|
Just discovered the tests, will add one thank you. Can you give me some guidance what is missing for the linting check? |
wanna have a quick vc? |
|
All you need is to run tfdoc on the blueprint, as explained in the contributing guide. Ping me if you want to do it together. |
|
I'll try to figure it out, I will ping you if I can't make it work. |
ludoo
approved these changes
Feb 24, 2023
juliocc
requested changes
Feb 24, 2023
juliocc
reviewed
Feb 24, 2023
juliocc
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a simple blueprint where a L7XLB is connecting to an application in another project via a PSC Neg. The application in turn is exposed internally via a L7ILB, that is exposed via PSC. The application is a Cloud Run service, but could be anything really.