Serverless networking program #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the identity that runs terraform is not included when creating a VPC SC perimeter, it loses control afterwards.
|
Wow! Can you add tests (examples if they make sense, or regular tests) otherwise it will be broken as soon as we touch one of the modules it uses. |
|
I added tests at the end of README that covers most of them, possibly missing modules only of the use case with VPN. I'll add one for that. |
|
@juliodiez can you merge this? I can do it otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blueprint to privately expose a Cloud Run service in a variety of use cases.
The content of this blueprint corresponds to the chapter 'Developing an enterprise application - The corporate environment' of the Serverless Networking Guide (to be released soon).