Fix Terraform formatting and add module_prefix attribute to modules_config #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonkovach
force-pushed
the
fast/fix-extras-0-cicd-github
branch
from
fae5be5 to
699a42e
Compare
ludoo
reviewed
Feb 19, 2023
antonkovach
changed the title
ludoo
approved these changes
Feb 19, 2023
antonkovach
changed the title
antonkovach
changed the title
antonkovach
changed the title
…hub repository population fix the formatting of Terraform files and adds the module/ prefix to the module path in 0-cicd-github under repository population. Without proper formatting and module path, generated repositories may show formatting mismatches and examples in the README.md file may not run as expected. The changes include updating the replace function with a new regular expression pattern to correctly apply the git source for modules and updating the each.value.file attribute to include the module/ prefix in the Terraform file path. This ensures that the examples in the README.md file work as intended and that the generated repositories follow best practices for Terraform code.
- Add module_prefix to modules_config - Add example to Readme.md - use module_prefix variable to specify the path
antonkovach
force-pushed
the
fast/fix-extras-0-cicd-github
branch
from
16d0e09 to
bfe74cb
Compare
ludoo
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the formatting of Terraform files in 0-cicd-github under repository population. Without proper formatting generated repositories may show formatting mismatches.
The module_prefix attribute has been added to the modules_config variable to handle non modules only repository use cases. The module_prefix attribute specifies the location of Terraform modules within the repository, which can help organize the modules and avoid naming conflicts.