Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless networking program #1146

Merged
merged 49 commits into from
Feb 10, 2023

Conversation

juliodiez
Copy link
Collaborator

Blueprint to publicly expose a Cloud Run service in a variety of use cases.

This content corresponds to the chapter 'My serverless "Hello, World! - Exploring Cloud Run' of the Serverless Networking Guide (to be released soon).

Follow CFF way, instead of using config files set appropriate values in file
variables.tf and use examples in the README to show how to tweak variables.
This way we can remove one var (glb_create) and simplify it for the user.
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice blueprint @juliodiez. Looking forward to reading the article too.

Besides the comments below, can I ask you to create a diagrams that are more similar in style to the rest of the diagrams in the repo?

blueprints/serverless/cloud-run-explore/variables.tf Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-explore/main.tf Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-explore/README.md Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-explore/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, just a few newlines missing in the README, and a nit which ofc feel free to ignore: I would move all images in an images/folder

@juliodiez juliodiez merged commit 3b865fa into GoogleCloudPlatform:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants