Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align VPN peer interface to module in FAST net VPN stage #1133

Conversation

simonebruzzechesse
Copy link
Collaborator

Fixed issue with module net-vpn-ha declared in vpn-onprem.tf for configuring HA VPN Tunnels from landing project to onprem. Due to a recent update of tunnels variable in the net-vpn-ha module the vpn ha tunnels configured in the networking-c-nva networking stage were not exporting custom routes due to mismatch in parameters shared and the expected ones (bgp_peer_options is indeed no more available in the tunnels variable object). Modifying the locals bgp_peer_options_onprem value and merging the options with bgp_peer parameters seems to have solve the issue (tested on my personal environment).

Updates to tunnels bgp_peer variable are related to this commit

…r version of tunnels variable available in the net-vpn-ha module
@juliocc juliocc requested a review from sruffilli February 6, 2023 18:22
@simonebruzzechesse simonebruzzechesse marked this pull request as ready for review February 7, 2023 10:10
@juliocc juliocc requested a review from ludoo February 7, 2023 11:59
@ludoo ludoo enabled auto-merge (squash) February 7, 2023 22:54
@ludoo
Copy link
Collaborator

ludoo commented Feb 7, 2023

Thanks Simone, well spotted and welcome to Fabric! :)

@ludoo ludoo changed the title Fixed issue with module net-vpn-ha declared in vpn-onprem.tf for stage 2-networking-c-nva Align VPN peer interface to module in FAST net VPN stage Feb 7, 2023
@ludoo ludoo merged commit 779c635 into GoogleCloudPlatform:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants